-
Notifications
You must be signed in to change notification settings - Fork 0
add polynomial-decay-helpers #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florence-bockting
wants to merge
16
commits into
main
Choose a base branch
from
add_polynomial_decay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3c28f26
add polynomial-decay-helpers
florence-bockting 329a3e0
create test for derivative and ensure it fails
florence-bockting cf252ce
create test for derivative and ensure it fails
florence-bockting 9406e24
fix derivative computation for cosine-decay
florence-bockting f3cb4d8
update test_convergence_integration with correct derivative function
florence-bockting 21ca429
add changelog
florence-bockting 5381e3d
add polynomial decay
florence-bockting d7761c4
add example with polynomial decay in tutorial
florence-bockting 194a208
add test for polynomial-decay-derivative
florence-bockting bf0a0bb
remove information about tests from changelog
florence-bockting 68de35b
add assert statement
florence-bockting 3ac6b34
add assert statement
florence-bockting cffb265
Merge pull request #17 from climate-resource/fix_derivative_cosine_decay
florence-bockting ffe55ad
Merge branch 'add_polynomial_decay' of https://github.com/climate-res…
florence-bockting 64929c6
add changelog
florence-bockting 7732ee1
fix type of return value for PolynomialDecaySplineHelperDerivative
florence-bockting File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| + include support for polynomial-decay (besides cosine-decay) | ||
| + we added three new classes/functions to the API in the module `convergence` | ||
| + `PolynomialDecaySplineHelper` | ||
| + `PolynomialDecaySplineHelperDerivative` | ||
| + `get_polynomial_decay_harmonised_spline` | ||
| + whereby the function `get_polynomial_decay_harmonised_spline` is mainly meant as user-interface | ||
| This function can be used as value for the `get_harmonise_spline` parameter in `harmonise`. | ||
| The function takes the same arguments as `get_cosine_decay_harmonised_spline` and additionally a | ||
| `power` argument. | ||
| + The `power` argument can be passed to the function using | ||
| `functools.partial(get_polynomial_decay_harmonised_spline, power=2)` | ||
| + An example use-case is added to the `getting-started-tutorial`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1 @@ | ||||||
| + fix computation of cosine decay derivative (we forgot a constant value in the formula) | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
(nwtkia) |
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow super thorough. I am normally much lazier than this when writing changelogs (especially given our current user base is us)
(nwtkia)
The CHANGELOG gets written in past tense. The reason is, when the user reads this, everything will have already been done.
I don't know why, but we use capitals for the start of each dot point.
(hwtatb)
The
[][]syntax allows you to do cross-references, which means that readers of the CHANGELOG can click and be taken straight to the module/code that is being discussed.