0.9.24 — rootless: bridge_add_member + bridge_del_member verbs#182
Merged
Conversation
Twenty-fifth 0.9.x release. Symmetric pair around IfconfigOps::bridgeAddMember / bridgeDelMember. Two new privops verbs (2-arg shape: bridge + member, both validated as iface names): bridge_add_member — wraps IfconfigOps::bridgeAddMember bridge_del_member — symmetric remove Same wire-up pattern as 0.9.23: privops_pure (enum + structs + validators), privops_wire_pure (JSON parse + format), privops_ nv_pure (nv parse), privops_client (build), privops_handlers (handle + dispatcher cases for both transports). CLI wiring in lib/run_net.cpp: 2 new privops-aware helpers, 2 call-site replacements (setupBridgeEpair add, destroyBridge Epair del). Add hard-fails; del soft-fails (RunAtEnd pattern). 2 new ATF tests + verb_token_roundtrips_for_every_verb update. Suite: 1296 -> 1298. Remaining iface verbs: set_iface_inet_addr (0.9.25), create_epair (0.9.26 — first response-data verb).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twenty-fifth 0.9.x release. Symmetric pair around
IfconfigOps::bridgeAddMemberandbridgeDelMember.What lands
Two new privops verbs
bridge_add_member— wrapsIfconfigOps::bridgeAddMember(bridge, member). Fields:bridge,member(both validated as iface names).bridge_del_member— symmetric remove.2-arg shape (different from 0.9.23's 1-arg verbs but same overall pattern). Validators delegate to existing
validateIfaceNamefor both fields.Wire-up
Same stack as 0.9.23 —
privops_pure,privops_wire_pure,privops_nv_pure,privops_client,privops_handlers. Each gains two new functions / cases.CLI wiring
lib/run_net.cppgets two new file-static helpers and 2 call-sites migrate:setupBridgeEpairline 481bridgeAddMember(bridgeIface, ifaceA)destroyBridgeEpairline 491bridgeDelMember(bridgeIface, ifaceA)bridgeAddMember— hard-fail (matches existing exception behaviour)bridgeDelMember— soft-fail (matches RunAtEnd teardown pattern; warn + continue)Test plan
bridge_add_member_minimal,bridge_del_member_minimal)verb_token_roundtrips_for_every_verbupdatedSeries state
CLI call-sites wired:
crate retune(0.9.15)crate stop(0.9.17)crate runZFS attach + detach (0.9.18)crate runnullfs mounts 8 sites (0.9.19)crate runvnet moveToVnet 4 sites (0.9.20)crate runremoveJail teardown (0.9.21)crate runcreateJail (0.9.22)crate runsetUp + disableOffload 5 sites (0.9.23)crate runbridge add + del 2 sites → bridge_add_member / bridge_del_member ← this PRRemaining iface verbs:
set_iface_inet_addr(3-arg)create_epair(first response-data verb)network_leaseper-user + RCTL umbrellaFiles
Same set as 0.9.23:
privops_pure.{h,cpp},privops_wire_pure.{h,cpp},privops_nv_pure.{h,cpp},privops_client.h,privops_client_pure.cpp,privops_handlers.{h,cpp},run_net.cpp,tests/unit/privops_pure_test.cpp,cli/args.cpp,CHANGELOG.md.Generated by Claude Code