0.9.23 — rootless: set_iface_up + disable_iface_offload verbs#181
Merged
Conversation
Twenty-fourth 0.9.x release. First verb-set expansion since
0.9.0. setUp + disableOffload are atomic single-iface
primitives that don't compose well with the existing
configure_iface composite verb.
Two new privops verbs:
set_iface_up — wraps IfconfigOps::setUp(ifname). Single
string arg, idempotent.
disable_iface_offload — wraps IfconfigOps::disableOffload.
Same shape; FreeBSD 15 checksum-offload workaround.
Stack-wide wire-up:
privops_pure: enum + structs + validators (delegate to
validateIfaceName)
privops_wire_pure: JSON parsers + format builders +
dispatcher cases
privops_nv_pure: nv parsers (FieldMap)
privops_client: buildSetIfaceUp / buildDisableIfaceOffload
privops_handlers: handlers + dispatcher cases (HTTP + nv)
CLI wiring: lib/run_net.cpp gets setUpPrivopsOrLocal and
disableOffloadPrivopsOrLocal file-static helpers (sibling
pattern to 0.9.20's moveToVnetPrivopsOrLocal). 5 call-sites
migrated (4 disableOffload + 1 setUp in createEpair /
setupBridgeEpair).
Why expand: configure_iface (0.9.6) assumes spec-driven
"give all at once" usage. run_net.cpp orchestration is
streaming. Atomic verbs match better. The 0.9.0 closed
taxonomy isn't broken — verbs append.
Suite: 1294 -> 1296. verb_token_roundtrips_for_every_verb
updated to include both new verbs.
Remaining iface verbs: bridge_add_member, set_iface_inet_addr
(0.9.24), create_epair (0.9.25, first response-data verb).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Twenty-fourth 0.9.x release. First verb-set expansion since 0.9.0 — adds two atomic single-iface verbs needed by
crate run's host-side bridge plumbing.What lands
Two new privops verbs
set_iface_up— wrapsIfconfigOps::setUp(ifname). Single string arg; idempotent.disable_iface_offload— wrapsIfconfigOps::disableOffload(ifname). Same shape; FreeBSD 15 checksum-offload workaround.Why these two together: same shape (1 ifname, no response data), called as a sibling pair in
run_net.cpp::setupBridgeEpair, splitting into separate releases would be unhelpful.Wire-up across the stack
lib/privops_pure.{h,cpp}— enum + request structs + validators (delegate to existingvalidateIfaceName)lib/privops_wire_pure.{h,cpp}— JSON parsers +formatXxxSuccessbuilders + dispatcher caseslib/privops_nv_pure.{h,cpp}— nv parsers (FieldMap)lib/privops_client.h+lib/privops_client_pure.cpp—buildSetIfaceUp/buildDisableIfaceOffloaddaemon/privops_handlers.{h,cpp}— handlers + dispatcher cases (HTTP + libnv transports)CLI wiring
lib/run_net.cppgets two new file-static helpers (setUpPrivopsOrLocal,disableOffloadPrivopsOrLocal) mirroring the 0.9.20moveToVnetPrivopsOrLocalpattern. 5 call-sites migrated:createEpairline 160disableOffload(ifaceA)createEpairline 161disableOffload(ifaceB)setupBridgeEpairline 436disableOffload(ifaceA)setupBridgeEpairline 437disableOffload(ifaceB)setupBridgeEpairline 440setUp(ifaceA)Why expand the verb set
configure_iface(0.9.6) bundles move + IP/MAC + bridge attach. Assumes spec-driven "give me everything at once" usage. Therun_net.cpporchestration is streaming — interleaves IfconfigOps calls with state-tracking and other ops. For that pattern, atomic verbs match better.The 0.9.0 closed taxonomy isn't broken; new verbs append to it.
Test plan
set_iface_up_minimal,disable_iface_offload_minimal)verb_token_roundtrips_for_every_verbupdated to include both new verbs (catches future enum-add-without-mapping)Series state
CLI call-sites wired:
crate retune→ set_rctl / clear_rctl (0.9.15)crate stop→ destroy_jail (0.9.17)crate runZFS attach + detach → attach_zfs / detach_zfs (0.9.18)crate runnullfs mounts (8 sites) → mount_nullfs (0.9.19)crate runvnet moveToVnet (4 sites) → configure_iface move-only (0.9.20)crate runremoveJail teardown → destroy_jail (0.9.21)crate runcreateJail → create_jail (0.9.22)crate runsetUp + disableOffload (5 sites) → set_iface_up / disable_iface_offload ← this PRRemaining:
bridge_add_member+set_iface_inet_addrverbscreate_epair(first response-data verb)network_leaseper-user paths + RCTL umbrellaFiles
lib/privops_pure.{h,cpp},lib/privops_wire_pure.{h,cpp},lib/privops_nv_pure.{h,cpp}— taxonomy + parserslib/privops_client.h+lib/privops_client_pure.cpp— buildersdaemon/privops_handlers.{h,cpp}— handlers + dispatcherlib/run_net.cpp— 2 helpers + 5 call-site replacementstests/unit/privops_pure_test.cpp— 2 new testscli/args.cpp—crate 0.9.23CHANGELOG.md— entryGenerated by Claude Code