fix: handle slow_down error
#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Babak K. Shandiz <babakks@github.com>
Signed-off-by: Babak K. Shandiz <babakks@github.com>
babakks
force-pushed
the
babakks/handle-slow-down
branch
from
8264ea8 to
5ffd590
Compare
BagToad
approved these changes
Dec 17, 2025
Member
BagToad
left a comment
BagToad
left a comment
There was a problem hiding this comment.
LGTM, changes make sense as we discussed.
| - uses: actions/checkout@v2 | ||
| - name: Setup Go | ||
| uses: actions/setup-go@v1 | ||
| uses: actions/setup-go@v6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
These changes handle the
slow_downerror in this way:intervalis provided by the error response, it'll increase the current interval by 5 seconds as per the RFC spec.intervalis provided, it'll use it. This is how GitHub OAuth API works (docs).New tests also cover the rare case of multiple
slow_downerrors.Note
I've also E2E tested the changes thanks to the sample code in
device/examples_test.go.