Skip to content

feature/cp-10779-implement-removeallnotifications#330

Merged
snuricp merged 3 commits intomasterfrom
feature/cp-10779-implement-removeallnotifications
Jan 30, 2026
Merged

feature/cp-10779-implement-removeallnotifications#330
snuricp merged 3 commits intomasterfrom
feature/cp-10779-implement-removeallnotifications

Conversation

@unnaticleverpush
Copy link
Contributor

@unnaticleverpush unnaticleverpush commented Jan 28, 2026

Implemented a new method removeAllNotifications in order to remove all notifications locally.


Note

Adds a public CleverPush.removeAllNotifications() method to clear locally stored notifications.

  • Removes CleverPushPreferences.NOTIFICATIONS_JSON and deprecated NOTIFICATIONS from SharedPreferences (prevents fallback reads)
  • Wrapped in try/catch with error logging

Written by Cursor Bugbot for commit 631a1de. This will update automatically on new commits. Configure here.


Summary by cubic

Added CleverPush.removeAllNotifications() to clear local notifications and remove deprecated storage to prevent fallback reads. Aligns with Linear CP-10779.

Written for commit 631a1de. Summary will update on new commits.

Implemented a new method `removeAllNotifications` in order to remove all notifications locally.
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Remove deprecated storage to prevent fallback reads
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="cleverpush/src/main/java/com/cleverpush/CleverPush.java">

<violation number="1" location="cleverpush/src/main/java/com/cleverpush/CleverPush.java:2970">
P2: removeAllNotifications only clears NOTIFICATIONS_JSON, but local notifications can still be loaded from the deprecated NOTIFICATIONS key when NOTIFICATIONS_JSON is null. Clearing both ensures all locally stored notifications are removed, including legacy data.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@snuricp snuricp merged commit bf7c046 into master Jan 30, 2026
4 of 6 checks passed
@snuricp snuricp deleted the feature/cp-10779-implement-removeallnotifications branch January 30, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants