feature/cp-10779-implement-removeallnotifications#330
Merged
Conversation
Implemented a new method `removeAllNotifications` in order to remove all notifications locally.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
Remove deprecated storage to prevent fallback reads
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="cleverpush/src/main/java/com/cleverpush/CleverPush.java">
<violation number="1" location="cleverpush/src/main/java/com/cleverpush/CleverPush.java:2970">
P2: removeAllNotifications only clears NOTIFICATIONS_JSON, but local notifications can still be loaded from the deprecated NOTIFICATIONS key when NOTIFICATIONS_JSON is null. Clearing both ensures all locally stored notifications are removed, including legacy data.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
snuricp
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a new method
removeAllNotificationsin order to remove all notifications locally.Note
Adds a public
CleverPush.removeAllNotifications()method to clear locally stored notifications.CleverPushPreferences.NOTIFICATIONS_JSONand deprecatedNOTIFICATIONSfromSharedPreferences(prevents fallback reads)Written by Cursor Bugbot for commit 631a1de. This will update automatically on new commits. Configure here.
Summary by cubic
Added CleverPush.removeAllNotifications() to clear local notifications and remove deprecated storage to prevent fallback reads. Aligns with Linear CP-10779.
Written for commit 631a1de. Summary will update on new commits.