Conversation
Fix removeNotification to also clear the group’s summary notification.
divocp
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix removeNotification to also clear the group’s summary notification.
Note
Fixes notification removal to also clean up group summaries when the last child is deleted.
removeNotification(...)to derive agroupKeyfrom the notification’s category and pass it toremoveGroupSummaries(...)removeGroupSummaries(...)(Android M+) to count active child notifications viaBadgeHelper.getActiveNotifications(...)and cancel a group’s summary when no children remain; skips the just-removed child and optionally filters by the provided group keyStatusBarNotificationand adds error handling/logging around cleanupWritten by Cursor Bugbot for commit 0ce811b. This will update automatically on new commits. Configure here.
Summary by cubic
Fixes removeNotification on Android to clear the group summary when its last child is removed. Addresses CP-10693 and prevents stale summary notifications.
Written for commit 0ce811b. Summary will update on new commits.