frature/cp-9875-android-dynamic-deep-links-track-event-pass-dynamic-deep#318
Draft
unnaticleverpush wants to merge 6 commits intomasterfrom
Draft
Conversation
If the notification URL contains a deeplinkId parameter, pass the value of that deeplinkId as a parameter to the trackEvent API call.
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
cleverpush/src/main/java/com/cleverpush/CleverPushPreferences.java
Outdated
Show resolved
Hide resolved
cleverpush/src/main/java/com/cleverpush/NotificationOpenedProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="cleverpush/src/main/java/com/cleverpush/NotificationOpenedProcessor.java">
<violation number="1" location="cleverpush/src/main/java/com/cleverpush/NotificationOpenedProcessor.java:111">
When a notification without a deeplink is opened, the previously stored deeplinkId remains in SharedPreferences, so later trackEvent calls still send the old deeplinkId within 60 minutes. Please clear the stored deeplink when the current notification has none.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
cleverpush/src/main/java/com/cleverpush/NotificationOpenedProcessor.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the notification URL contains a deeplinkId parameter, pass the value of that deeplinkId as a parameter to the trackEvent API call.
Note
Captures deeplinkId from notification URL on open, stores it with timestamp, and adds it to trackEvent payload if within 60 minutes.
CleverPush.trackEvent(...): AddsdeeplinkIdto/subscription/conversionpayload when a recent (<=60m) stored deeplink is available; continues including recentnotificationId.NotificationOpenedProcessor: ParsesdeeplinkIdfrom notification URL and savesLAST_CLICKED_NOTIFICATION_DEEPLINK_IDand timestamp on click.CleverPushPreferences: AddsLAST_CLICKED_NOTIFICATION_DEEPLINK_IDandLAST_CLICKED_NOTIFICATION_DEEPLINK_TIMEkeys.Written by Cursor Bugbot for commit f4341b2. This will update automatically on new commits. Configure here.
Summary by cubic
Adds dynamic deep link attribution for Android: when a notification URL includes deeplinkId, we capture it and include it in trackEvent for 60 minutes after the click. Addresses Linear CP-9875.
Written for commit 93712ac. Summary will update automatically on new commits.