Fixes some 404s and adds routable docs link validation#3197
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
9 tasks
SarahSoutoul
approved these changes
Mar 10, 2026
NWylynko
reviewed
Mar 12, 2026
NWylynko
reviewed
Mar 12, 2026
NWylynko
reviewed
Mar 12, 2026
NWylynko
reviewed
Mar 12, 2026
NWylynko
reviewed
Mar 12, 2026
NWylynko
reviewed
Mar 12, 2026
- Add JSDoc to getRoutableDocHref explaining its purpose - Explain what vfileMessage.fatal = true does in safeError - Document why skipWriteDist still needs temp dir cleanup - Clarify why routableDocsMap and docsMap are separate maps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Link validation already runs via pnpm dev and pnpm build, making a separate lint step redundant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NWylynko
reviewed
Mar 23, 2026
The build already fails on any reporter output (warnings included), so the severity change was unnecessary. The actual fix that catches broken links is validating against routableDocsMap instead of docsMap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NWylynko
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔎 Previews:
What does this solve? What changed?
docs/getting-started/quickstart/overview.mdxwas not being caught by the normalpnpm lintpath.docsMap, which included synthetic SDK-scoped aliases that do not always correspond to real emitted routes.lint:check-linksso link validation runs as part of the existing lint surface without writingdist/./docs/upgrade-guides/core-3→/docs/guides/development/upgrading/upgrade-guides/core-3.Deadline
Other resources