fix: update JavaScript quickstart for clerk-js v6#3177
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jacekradko Okay gave this a bit of a polish with the docs review. I'm not super keen on approving this right away for several reasons:
@manovotny would you be able to give this a look too? |
Co-authored-by: Michael Novotny <manovotny@gmail.com>
|
@jacekradko should we be applying these changes: https://github.com/clerk/dashboard/pull/8779/changes/d99c2509a0ccb982778f4749142b836f544ca11f on here too? |
@SarahSoutoul yes, but let the reviews/changes settle there first. |
|
@SarahSoutoul @manovotny The code examples are now aligned with the dashboard |
@jacekradko you said "not", but I'm guessing you meant "now"? cbee428 looks like alignment. |
manovotny
left a comment
There was a problem hiding this comment.
Updates LGTM. @SarahSoutoul should give her 👍 too.
|
@manovotny Yep! I totally meant NOW, not NOT 🤣 |

Order of deployment
Summary
@clerk/ui@1UI bundle loading to both the NPM module and<script>tag approaches@clerk/clerk-js@5to@clerk/clerk-js@6ui: { ClerkUI: window.__internal_ClerkUICtor }toclerk.load()in all code examplesVITE_CLERK_FRONTEND_API_URLenv var and uses it to load the UI bundle (consistent with{{fapi_url}}in the<script>tag approach)Context
The JavaScript quickstart guide was missing the required UI bundle loading step for
@clerk/clerk-jsv6. Without this, users following the guide would not see any prebuilt components rendered. The guide also referenced@clerk/clerk-js@5in CDN URLs and derived the frontend API domain from the publishable key instead of using an env var.Verified against the reference repo: https://github.com/jacekradko/clerk-javascript-quickstart
Test plan
<script>tag examples work end-to-end in a plain HTML file