Fix: can hop to anchor links that occur towards the end of the page#124
Open
fergiemcdowall wants to merge 1 commit intoclenemt:masterfrom
Open
Fix: can hop to anchor links that occur towards the end of the page#124fergiemcdowall wants to merge 1 commit intoclenemt:masterfrom
fergiemcdowall wants to merge 1 commit intoclenemt:masterfrom
Conversation
…00vh (the height of the page in the browser window). This enables the user to always be able to access anchor points at the bottom of the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
You can't hop to anchor links that occur towards the end of the page if there is not enough room below them. Problem is even more pronounced when using vertical, "portrait" monitors.
Solution:
Add white space to the bottom of the footer that is always equal to 100vh (the height of the page in the browser window). This enables the user to always be able to access anchor points at the bottom of the page