Feature: CORE-37261: transport framing#32
Merged
Conversation
twallis-cpr
requested review from
luis-camero and
nnarain-cpr
and removed request for
a team
nnarain-cpr
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the larger proton re-architecture here (internal CPR/OTTO employee eyes only 👀 )
This PR reorganizes the serial transport functions from protonc and adds a new UDP4 transport header for future revisions of the protocol.
The existing serial spec is unchanged, and will likely not be changed in the future. The serial functionality was retained, but the function names were updated to denote that they're specifically for the serial framing, rather than the generic name they had. The functions were moved into
core/transport/serial.candcore/include/proton/transport/serial.h. They were previously incommon.h.Existing dependencies on the serial framing (examples, and protoncpp) were updated to temporarily use the new serial.h/serial.c files, before we liquidate them as part of the overall refactor.
Also, added some (admittedly AI generated) unit tests for serial and UDP4 framing. The logic is simple enough.