Add callback table with user args#31
Merged
twallis-cpr merged 6 commits intoMay 21, 2026
Merged
Conversation
twallis-cpr
requested review from
luis-camero and
nnarain-cpr
and removed request for
a team
nnarain-cpr
reviewed
May 21, 2026
| { | ||
| for (size_t i = 0; i < registry->bundle_count; i++) | ||
| { | ||
| if (registry->bundle_id_lut[i].id == bundle_id) |
There was a problem hiding this comment.
(Understanding I missed some MRs while on vacation)
How often is this function going to fire? Can the callback be cached in a way that you don't have to do the linear search each time?
Contributor
Author
There was a problem hiding this comment.
That's kinda what the LUT was for, but yeah the linear search is done each time.
nnarain-cpr
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the larger proton re-architecture here (internal CPR/OTTO employee eyes only 👀 )
This feature branch re-adds the per-bundle decode callbacks from the original
protonclibrary. However, instead of using weak linking. The motive for moving to "strong" linking here is largely to reduce complexity in autogen, and to provide users with the ability to not use a name-dependent function, and to even have a central signal decoding callback.