feat(cache): add backward compatibility for pako 1.x to 2.x migration#1383
Merged
JamieMagee merged 3 commits intoclearlydefined:masterfrom Jan 30, 2026
Merged
Conversation
JamieMagee
reviewed
Jan 14, 2026
| service: config.get('CACHING_REDIS_SERVICE'), | ||
| apiKey: config.get('CACHING_REDIS_API_KEY'), | ||
| port: Number(config.get('CACHING_REDIS_PORT')) || 6380 | ||
| port: Number(config.get('CACHING_REDIS_PORT')) |
Contributor
There was a problem hiding this comment.
Was the removal of || 6380 here intentional? redis.js has it in the function signature default, and config.js has added the fallback.
JamieMagee
reviewed
Jan 14, 2026
Comment on lines
+127
to
+128
| "pako": "^2.1.0", | ||
| "pako-1": "npm:pako@^1.0.8" |
Contributor
There was a problem hiding this comment.
nit: sort alphabetically.
JamieMagee
approved these changes
Jan 14, 2026
qtomlinson
reviewed
Jan 23, 2026
Collaborator
qtomlinson
left a comment
There was a problem hiding this comment.
Thanks for adding the migration and the unit tests!
c72ba89 to
19da150
Compare
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
Signed-off-by: ElaineDeMattosSilvaB <elaine.de-mattos-silva-bezerra@deutschebahn.com>
19da150 to
b7e2c03
Compare
ryanbrandenburg
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as part of the Node.js and package updates effort (#1340), here is the follow-up PR that adds backward compatibility to handle Redis cache entries compressed with both pako 1.x (binary string) and pako 2.x (base64) formats, preventing cache invalidation during the upgrade.
Summary
Adds backward compatibility to handle Redis cache entries compressed with both pako 1.x (binary string) and pako 2.x (base64) formats, preventing cache invalidation during the upgrade.
Changes
redis.js: Automatically detects whether cached data is in old binary string format (pako 1.x) or new base64 format (pako 2.x)def_*(definitions) andhrv_*(harvest) key patternsTesting
pako@1.0.8andpako@2.1.0to prove cross-version compatibilityBenefits