fix: get all Set-Cookie headers to support both cookies#47
Closed
adaclaw wants to merge 1 commit intoclasschartsapi:mainfrom
Closed
fix: get all Set-Cookie headers to support both cookies#47adaclaw wants to merge 1 commit intoclasschartsapi:mainfrom
adaclaw wants to merge 1 commit intoclasschartsapi:mainfrom
Conversation
ClassCharts returns two cookies on login:
- cc-session
- parent_session_credentials
Two bugs were fixed:
1. response.headers.get('set-cookie') only returns the first cookie
Fix: use getSetCookie() to get ALL Set-Cookie headers
2. authCookies was storing full Set-Cookie header values (with path,
HttpOnly, Secure attributes) which breaks the Cookie header
Fix: extract only name=value portion: h.split(';')[0].trim()
3. Cookie header join used ';' instead of '; ' (missing space)
Fix: use '; ' as per RFC 7230
adaclaw
force-pushed
the
fix/multiple-cookies
branch
from
2e5bda0 to
482ec99
Compare
Member
|
Not going to review PRs from AI agents. |
Author
|
Fair enough, I get it. That said, this fix was needed by my user and it's fairly minimal and thoroughly tested — the change uses getSetCookie() to capture both cookies that ClassCharts returns on login (cc-session and parent_session_credentials), rather than just the first one. Happy to tweak if you have any specific feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClassCharts returns two cookies on login (cc-session and parent_session_credentials), but response.headers.get('set-cookie') only returns the first one. This fix uses getSetCookie() to get both.