Open
Conversation
|
Deploy preview for knit-ui ready! Built with commit 520b89f |
Contributor
Author
|
@anshumanv Reminder for review. |
Contributor
|
Oops my bad, on it. 👍 |
anshumanv
suggested changes
May 5, 2020
Contributor
anshumanv
left a comment
anshumanv
left a comment
There was a problem hiding this comment.
Can you add test for this too?
anshumanv
reviewed
May 5, 2020
| import { BannerAlertWrapper } from "./StyledAlert" | ||
|
|
||
| const BannerAlert = (props: BannerAlertProps) => { | ||
| const alertMountNode = document.createElement("div") |
Contributor
There was a problem hiding this comment.
Instead of creating a new node in the document, can we instead use the application root node?
This node will otherwise keep lying in the DOM unused, and more will be created everytime we render this
Contributor
There was a problem hiding this comment.
Or make it configurable to use a mount node, we can supply mount node form the app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.