Check continuation block to detect Rock Ridge version#138
Open
danigm wants to merge 1 commit intoclalancette:masterfrom
Open
Check continuation block to detect Rock Ridge version#138danigm wants to merge 1 commit intoclalancette:masterfrom
danigm wants to merge 1 commit intoclalancette:masterfrom
Conversation
This patch moves the _set_rock_ridge method call after the continuation
is parsed and sets the max version detected between dr_entries and
ce_entries.
This issue was detected parsing new openSUSE Tumbleweed iso. Looks like
mkisofs starts using continuation area ('CE') blobs if file name length
is > 92 and PX record could be there, affecting the version detection:
https://bugzilla.suse.com/show_bug.cgi?id=1209983#c15
Author
|
This is the code used to reproduce the error reported: #!/usr/bin/python3.13
import sys
import pycdlib
iso = pycdlib.PyCdlib()
iso.open(sys.argv[1])
for child in iso.list_children(iso_path='/'):
print(child.file_identifier())
iso.close()When run with the latest Tumbleweed iso https://download.opensuse.org/tumbleweed/iso/openSUSE-Tumbleweed-DVD-x86_64-Current.iso. Run with master version: Run with patched version: |
|
I encountered this error as well and need this fix. When will it be merged? Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves the _set_rock_ridge method call after the continuation is parsed and sets the max version detected between dr_entries and ce_entries.
This issue was detected parsing new openSUSE Tumbleweed iso. Looks like mkisofs starts using continuation area ('CE') blobs if file name length is > 92 and PX record could be there, affecting the version detection: https://bugzilla.suse.com/show_bug.cgi?id=1209983#c15