Open
Conversation
|
It would be really nice to have this merged. We are using your library in the ScummVM project (https://scummvm.org), and this is one of the problem we faced with: the Hybrid Mac/Windows CDs with Japanese filenames have the encoding lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my attempt at providing an updated version of #124. Comparing to that PR, I have:
get_file_from_isoin line with that section of the codeNonedefault when using.getas the default is Nonewalkwhich ignored the default encoding when callingself.list_childrenTest results as output by Github Actions: