chore: clean up lr-teams-icon-strip TODO aliases in sidebar-users.js#258
Merged
Merged
Conversation
Contributor
|
clagentic gate-note — merged by
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up three TODO(lr-teams-icon-strip) comments in sidebar-users.js and their corresponding call sites.
handleAgentsList (sidebar-users.js): The no-op stub was imported by app-messages.js as handleAgentsListTeam and called redundantly alongside the real handleAgentsList from agent-picker.js. Removed the import alias and the duplicate call in the agents_list message case. Removed the stub export from sidebar-users.js entirely. The TODO is gone.
renderUserStrip (sidebar-users.js): The no-op stub was imported and called in two places: app-messages.js (projects_updated case) and app.js (import-only, no active call site). Removed the call in app-messages.js, the import in app-messages.js, the import in app.js, and the export from sidebar-users.js. The TODO is gone.
updateDmBadge (sidebar-users.js): Genuine future feature. Export and no-op body retained. TODO replaced with a plain forward-looking comment. Still imported and called by app-messages.js on dm_message.
Task: lr-9b0f
Tests: npm test 309/309 pass. ESM named-import resolution check confirms no broken imports after the removals.