test: add test by gpBlockchain · Pull Request #237 · ckb-js/nexus

gpBlockchain · 2023-04-18T03:21:03Z

What Changed

Resolve #223
This PR dependent on #239

add create wallet && import wallet test

Motivation

Change Type

Indicate the type of change your pull request is:

documentation
patch
minor
major

codecov · 2023-04-18T03:26:35Z

Codecov Report

Merging #237 (75d4b24) into main (bc64adb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #237   +/-   ##
=======================================
  Coverage   75.88%   75.88%           
=======================================
  Files          62       62           
  Lines        1497     1497           
  Branches      216      216           
=======================================
  Hits         1136     1136           
  Misses        337      337           
  Partials       24       24

Impacted Files	Coverage Δ
packages/utils/src/env.ts	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

zhangyouxin · 2023-04-23T08:36:25Z

+    await page.getByLabel('Name').fill(existName);
+    await page.getByLabel('URL').fill('https://testnet.ckbapp.dev/');
+    await page.getByRole('button', { name: 'Add' }).click();
+    await page.getByText(existName).allInnerTexts();


we should get inner tests and asset it to contain two Testnet

zhangyouxin · 2023-04-23T08:36:26Z

+    expect('').toBe('failed');
+  });
+
+  it('should get networkChange that the url is not in whitelist', async () => {


seems this test case should be moved to "change-network.test.ts"

It seems a duplicate test, I will remove it.

zhangyouxin · 2023-04-23T08:36:27Z

+  });
+
+  it('should get networkChange that the url is not in whitelist', async () => {
+    await page.evaluate(() => {


Is the purpose of this patch watching current nexus network? maybe use ckb_getBlockchainInfo instead

zhangyouxin · 2023-04-23T08:36:29Z

+   */
+  it.todo('should work that add 192.168.. url');
+
+  it('should work that add url is http', async () => {


should wallet_enable work that add url prefix is http

zhangyouxin · 2023-04-23T08:36:32Z

+    });
+    expect(ckbNetworkName).toBe('ckb_testnet');
+  });
+  it('should get ckb name that change network is user added', async () => {


looks like a composed test case for "add network" and "change network", is it necessary?

IronLu233 · 2023-05-04T08:05:56Z

+
+DefaultTestEnv.setupTest({ initWalletWithDefaults: true });
+
+describe('Show account details', function () {


We should not use word account as a term on UTXO wallet.

IronLu233 · 2023-05-04T08:07:51Z

+
+  it('should get networkChange that the url is not in whitelist', async () => {
+    await page.evaluate(() => {
+      // @ts-ignore


Do not need it anymore.

IronLu233 · 2023-05-04T08:10:14Z

+    await page.getByRole('button', { name: 'Next' }).click();
+  });
+
+  it('should warn when the input password is too short', async () => {


In the UI, it is not a warning, it is a error when user input is not correct.
So using word error is more clear.

* docs: rule-based ownership skeleton Signed-off-by: homura <homura.dev@gmail.com> * docs: example for p2sh upgrade Signed-off-by: homura <homura.dev@gmail.com> * feat: a testkit pkg for unit test Signed-off-by: homura <homura.dev@gmail.com> * docs(testkit): jest example Signed-off-by: homura <homura.dev@gmail.com> * docs: custody-unlocking and serialization * fix(deps): update dependency zustand to v4.3.7 * chore(deps): update jest monorepo * chore(deps): update dependency @types/chrome to v0.0.233 * chore(deps): update dependency @auto-it/upload-assets to v10.45.0 * feat(detect-ckb): a module for detecting injected ckb * fix(ownership-providers): inject witness and cellDeps auto * chore: unnecessary root babel config * chore: examples with provider * chore: update lock file * fix: eslint * feat(detect-ckb): detecting injected ckb test cases * test(ownership-providers): update failed test cases * chore(detect-ckb): consistent nexus pkg version * chore(example): tip when nexus is not installed * chore: update lock file * fix(ownership-providers): inject witness and cellDeps auto * test(ownership-providers): update failed test cases * fix(extension-chrome): receiving end does not exist * feat(extension-chrome): add method `signTransaction` * fix: protocol doc not generated * refactor: refactor code * fix: not works on real world data * test: refine unit tests * refactor: simplify rpc object parse * docs: tutorial * chore: update lock file * chore(deps): update dependency prettier to v2.8.8 * feat: remove witness from existing input lock * Update CHANGELOG.md [skip ci] * Bump manifest version to: 0.0.16 [skip ci] * Bump version to: v0.0.16 [skip ci] * refactor(detect-ckb): customizable types of detected ckb * test(detect-ckb): eslint error since no floating promise * chore: show tx hash after sending tx in example * chore: update lock file * chore: update lock file * refactor: rm unnecessary code * test: rm unused cases * feat(ownership-provider): Ownership provider send transaction * revert(ownership-provider): revert payFee and sign * chore: fix incorrect coverage in code cov * chore: fix release error * chore: run e2e test before release * docs: explain for `byOutputIndexes` when `payFee` * Update CHANGELOG.md [skip ci] * Bump manifest version to: 0.0.17 [skip ci] * Bump version to: v0.0.17 [skip ci] * fix(ownership-provider): add method `isOwnedByWallet` * feat: a ckb node wrapper in js * fix(ownership-provider): support unsigned transaction * fix: e2e CI error * feat(ownership-providers): support payFee and signTransaction in send transaction * chore: the real ts coverage * refactor: Top-to-bottom implementation * feat: find out ownedLocks when signTransaction * chore: avoid chrome extension error * fix: filter type script cell when pay fee * refactor(e2e): make the config more clear * chore: extract `isDerivedLocks` move into ScriptInfoDb * test(e2e): added a transfer test * docs(e2e): how to launch an e2e node * test: add unit test for send transaction * fix: @nexus-wallet/testkit depended on extension-chrome move to `devDependencies` * Update CHANGELOG.md [skip ci] * Bump manifest version to: 0.0.18 [skip ci] * Bump version to: v0.0.18 [skip ci] * test: modify code for coverage * chore: avoid merge failures * refactor: modify toml config * refactor: use lodash.random instead of random * refactor: remove unused choose-port * fix: logic bug * chore: update package-lock * test: make txWithFee calculation more clear * refactor: use extended map for clearify code * refactor: optimize Map structures * chore: fix release error in pipeline * Update CHANGELOG.md [skip ci] * Bump manifest version to: 0.0.19 [skip ci] * Bump version to: v0.0.19 [skip ci] * test: refine e2e test case name --------- Signed-off-by: homura <homura.dev@gmail.com> Co-authored-by: homura <homura.dev@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: pygman <pygman@aliyun.com> Co-authored-by: zhangyouxin <zhangyouxingg@126.com> Co-authored-by: github-actions <github-actions@github.com>

test: add create wallet && import wallet test

39ddfdc

homura added the tests Add or improve existing tests label Apr 18, 2023

gpBlockchain and others added 7 commits April 18, 2023 11:55

test: add account-detail test

5fc4b91

test: add add-network test && add-whitelist-site test

89b8803

test: add network change test

a0d13e5

Merge branch 'ckb-js:main' into test/add-e2e

f86c1d9

test: change https url

b686822

test: click btn with exact

a0aff73

test: click btn with exact

4a28559

gpBlockchain changed the title ~~test: add create wallet && import wallet test~~ test: add test Apr 19, 2023

gpBlockchain and others added 6 commits April 19, 2023 11:35

test: add search todo

37c5e08

test: add ckb get blockchain info test

c1c1941

Merge branch 'ckb-js:main' into test/add-e2e

2a0046f

test: remove todo func

8f1675a

Merge remote-tracking branch 'origin/test/add-e2e' into test/add-e2e

f012539

Merge branch 'ckb-js:main' into test/add-e2e

c79d402

zhangyouxin reviewed Apr 23, 2023

View reviewed changes

IronLu233 reviewed May 4, 2023

View reviewed changes

IronLu233 and others added 2 commits May 4, 2023 17:27

Merge branch 'main' into test/add-e2e

75d4b24

IronLu233 approved these changes May 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add test#237

test: add test#237
gpBlockchain wants to merge 16 commits intockb-js:mainfrom
gpBlockchain:test/add-e2e

gpBlockchain commented Apr 18, 2023 •

edited by homura

Loading

Uh oh!

codecov Bot commented Apr 18, 2023 •

edited

Loading

Uh oh!

zhangyouxin Apr 23, 2023

Uh oh!

zhangyouxin Apr 23, 2023

Uh oh!

IronLu233 May 4, 2023

Uh oh!

zhangyouxin Apr 23, 2023

Uh oh!

zhangyouxin Apr 23, 2023

Uh oh!

zhangyouxin Apr 23, 2023

Uh oh!

IronLu233 May 4, 2023

Uh oh!

IronLu233 May 4, 2023

Uh oh!

IronLu233 May 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		DefaultTestEnv.setupTest({ initWalletWithDefaults: true });

		describe('Show account details', function () {

Conversation

gpBlockchain commented Apr 18, 2023 • edited by homura Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Motivation

Change Type

Uh oh!

codecov Bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gpBlockchain commented Apr 18, 2023 •

edited by homura

Loading

codecov Bot commented Apr 18, 2023 •

edited

Loading