Skip to content

feat(extension-chrome): use design system to simplify code#195

Open
IronLu233 wants to merge 12 commits intomainfrom
design-system
Open

feat(extension-chrome): use design system to simplify code#195
IronLu233 wants to merge 12 commits intomainfrom
design-system

Conversation

@IronLu233
Copy link
Copy Markdown
Contributor

@IronLu233 IronLu233 commented Apr 11, 2023

What Changed

https://www.figma.com/file/x49RWTMPXmN5UgbaCAkraN/wallet?node-id=982-1329&t=qvCEVarGM3jZN3sn-0

implement the UI on HIFI(updated)

Motivation

for making the UI more clear.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

nexus--canary.195.4697587484.zip

📦 Published PR as canary version: 0.0.14--canary.195.4697587484.0

✨ Test out this PR locally via:

npm install @nexus-wallet/ownership-providers@0.0.14--canary.195.4697587484.0
npm install @nexus-wallet/protocol@0.0.14--canary.195.4697587484.0
npm install @nexus-wallet/utils@0.0.14--canary.195.4697587484.0
# or 
yarn add @nexus-wallet/ownership-providers@0.0.14--canary.195.4697587484.0
yarn add @nexus-wallet/protocol@0.0.14--canary.195.4697587484.0
yarn add @nexus-wallet/utils@0.0.14--canary.195.4697587484.0

@IronLu233 IronLu233 self-assigned this Apr 11, 2023
@IronLu233 IronLu233 marked this pull request as draft April 11, 2023 09:39
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (c122156) to head (4c76c53).
⚠️ Report is 193 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files          45       45           
  Lines         872      872           
  Branches      114      114           
=======================================
  Hits          751      751           
  Misses         20       20           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@IronLu233 IronLu233 changed the title Design system feat(extension-chrome): use design system to simplify code Apr 11, 2023
@IronLu233 IronLu233 marked this pull request as ready for review April 11, 2023 11:39
@IronLu233 IronLu233 mentioned this pull request Apr 11, 2023
3 tasks
},
}));

export const Input = defineMultiStyleConfig({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Input a multipart component?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread packages/extension-chrome/src/pages/WalletManager/containers/RecoveryWallet.tsx Outdated
@homura homura added the minor Increment the minor version when merged label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants