Skip to content

refactor: extract request with retry to a stateless function#170

Open
zhangyouxin wants to merge 2 commits intockb-js:mainfrom
zhangyouxin:refetch-bug
Open

refactor: extract request with retry to a stateless function#170
zhangyouxin wants to merge 2 commits intockb-js:mainfrom
zhangyouxin:refetch-bug

Conversation

@zhangyouxin
Copy link
Copy Markdown
Contributor

What Changed

This PR refactors extract ownership backend fetch request with retry and timeout to a stateless function. And changed corresponding test case.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@zhangyouxin zhangyouxin changed the title [refactor]: extract request with retry to a stateless function refactor: extract request with retry to a stateless function Mar 29, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 29, 2023

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.91%. Comparing base (ad56928) to head (0e4f3d4).
⚠️ Report is 351 commits behind head on main.

Files with missing lines Patch % Lines
...n-chrome/src/services/ownership/backend/request.ts 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   86.79%   86.91%   +0.11%     
==========================================
  Files          40       41       +1     
  Lines         765      772       +7     
  Branches       94       94              
==========================================
+ Hits          664      671       +7     
  Misses         20       20              
  Partials       81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant