Skip to content

Fix fire onEnter callback anyway when parent isn't display #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xyy94813 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix fire onEnter callback anyway when parent isn't display #344

xyy94813 wants to merge 1 commit into from

Conversation

@xyy94813
Copy link

@xyy94813 xyy94813 commented Feb 4, 2021

Fix #328

@xyy94813 xyy94813 force-pushed the feature/notFireIfNotDisplay branch from 1709484 to d75ef7d Compare May 17, 2021 04:36
@xyy94813
Copy link
Author

xyy94813 commented Aug 19, 2021

Is there any maintainer?
Give me some feedback plz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ferleonardo ferleonardo ferleonardo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When parent is hidden, it will fire onEnter callback anyway

2 participants

@xyy94813 @ferleonardo