Skip to content

Add PostgreSQL 16 core package build for Ubuntu focal#1182

Draft
kemalbuyukkaya wants to merge 7 commits into
developfrom
pg16-focal
Draft

Add PostgreSQL 16 core package build for Ubuntu focal#1182
kemalbuyukkaya wants to merge 7 commits into
developfrom
pg16-focal

Conversation

@kemalbuyukkaya

Copy link
Copy Markdown
Collaborator

PGDG dropped PostgreSQL 16 binaries for Ubuntu 20.04 (focal) after focal reached EOL standard support; the last official focal build was 16.9-1.pgdg20.04+1. This adds a standalone, signed build pipeline that rebuilds newer 16.x core packages for focal.

Approach (validated locally, produces the full 13-package set that installs and runs on stock focal with working JIT):

  • Combine the newer upstream orig.tar.bz2 with the focal-era debian/ packaging (16.9-1.pgdg20.04+1), whose default toolchain (clang/llvm-dev = LLVM 10) yields focal-native dependencies (libicu66, libssl1.1, libldap-2.4-2, libllvm10) rather than the clang-19/llvm-19 required by newer packaging.
  • Restore the removed focal-pgdg build tooling (debhelper 13, dh-exec, postgresql-common-dev) from apt-archive.postgresql.org.
  • Drop the obsolete hurd-iovec patch (merged upstream as of 16.14) and gate on the full quilt series applying cleanly so future drift fails loudly.
  • Sign packages with the existing debsigner image (debsigs --sign=maint).

The minor version is parameterized: set PG_UPSTREAM_VERSION (workflow input pg_upstream_version) to build e.g. 16.15; the orig/debian checksums are auto-resolved from the official .dsc unless pinned.

Files:

  • dockerfiles/pg16-focal-builder/Dockerfile: focal builder image
  • scripts/build_pg16_focal: fetch/verify/assemble/build entrypoint
  • .github/workflows/build-pg16-focal.yml: build -> sign -> verify -> upload

@microsoft-github-policy-service

Copy link
Copy Markdown

@kemalbuyukkaya please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@mtuncer

mtuncer commented Jun 17, 2026

Copy link
Copy Markdown
Member

we need to build all PG versions we can build not just 16. try to make it parameterized if possible.
Also think about parameterizing PG minor version so that we won't have to change the script each time PG releases a new minor.

@mtuncer

mtuncer commented Jun 17, 2026

Copy link
Copy Markdown
Member

also, we might want to keep this in its own branch and not merge it into develop, please check with Ibrahim

PGDG dropped PostgreSQL 16 binaries for Ubuntu 20.04 (focal) after focal
reached EOL standard support (last official focal build: 16.9-1.pgdg20.04+1).
This adds a standalone, signed pipeline that rebuilds newer 16.x core packages
for focal.

Approach (validated locally; produces the full 13-package set that installs and
runs on stock focal with working JIT):
- Combine the newer upstream orig.tar.bz2 with the focal-era debian/ packaging
  (16.9-1.pgdg20.04+1), whose default toolchain (clang/llvm-dev = LLVM 10)
  yields focal-native dependencies (libicu66, libssl1.1, libldap-2.4-2,
  libllvm10) instead of the clang-19/llvm-19 required by newer packaging.
- Restore the removed focal-pgdg build tooling (debhelper 13, dh-exec,
  postgresql-common-dev) from apt-archive.postgresql.org.
- Drop the obsolete hurd-iovec patch (merged upstream as of 16.14) and gate on
  the full quilt series applying cleanly so future drift fails loudly.
- Sign with the existing debsigner image (debsigs --sign=maint), using the
  pg-azure-storage signing secrets (PGAZ_PACKAGE_SECRET_KEY /
  PGAZ_PACKAGE_PASSPHRASE), matching build-pgazure-nightlies.yml.

The minor version is parameterized: set PG_UPSTREAM_VERSION (workflow input
pg_upstream_version) to build e.g. 16.15; the orig/debian checksums are
auto-resolved from the official .dsc unless pinned.

Files:
- dockerfiles/pg16-focal-builder/Dockerfile: focal builder image
- scripts/build_pg16_focal: fetch/verify/assemble/build entrypoint
- .github/workflows/build-pg16-focal.yml: build -> sign -> verify -> upload
The packaging signing secrets in this repo (incl. PGAZ_PACKAGE_SECRET_KEY) are
stored as raw ASCII-armored keys, not base64. import_and_sign assumed base64 and
ran `base64 -d` first, which fails on armored input ("base64: invalid input" ->
"no valid OpenPGP data found" -> "secret key not available").

Detect the format: import ASCII-armored keys directly, otherwise base64-decode
as before (backward compatible). Also verify a PRIVATE key was actually imported
and exit non-zero with an actionable message if only a public key is present, so
debsigs never silently emits unsigned packages.

Validated in the xenial debsigner image: armored private key -> signs
(_gpgmaint added); base64 key -> signs; armored public-only key -> exits 78.
build-package.yml and build-package-test.yml trigger on every branch
(branches: "**") and run the Citus extension build plus test_build_packages,
which is unrelated to the PostgreSQL-core focal pipeline and fails here on a
pre-existing PACKAGING_PASSPHRASE mismatch. Exclude pg16-focal via
branches-ignore so it no longer blocks this work; workflow_dispatch stays.
Roll back the earlier workarounds now that signing uses the prebuilt
citusdata/packaging:debsigner image:
- dockerfiles/debsigner/scripts/import_and_sign: back to upstream (we no longer
  build our own signer, so the armored-key handling is unnecessary).
- build-package.yml / build-package-test.yml: restore branches: "**" (drop the
  pg16-focal branches-ignore guard) to avoid touching shared extension CI.

These three files now match develop; only the PostgreSQL-core focal pipeline
remains in this branch.
The signer images are maintained out-of-band (not built by this repo's image
pipeline), so the deployed citusdata/packaging:debsigner has drifted from
dockerfiles/debsigner. Building our own signer from that source could not import
the same signing key that signs every other Citus package, while the deployed
image does (pg-azure-storage nightlies are green with PGAZ_PACKAGE_SECRET_KEY).

Use the prebuilt citusdata/packaging:debsigner with a Docker Hub login and pipe
the passphrase via stdin + env, mirroring citus_package.sign_packages. Pin the
job to ubuntu-20.04 to match the green pg-azure-storage signing pipeline.
Revert the ubuntu-20.04 pin to ubuntu-latest to stay future-proof as GitHub
retires the hosted ubuntu-20.04 image. Signing uses the prebuilt
citusdata/packaging:debsigner image (same as all-citus, which signs fine on
ubuntu-latest), so the runner version is not the relevant factor.
PGAZ_PACKAGE_SECRET_KEY is only referenced on the pg-azure-storage branches and
did not import in our run. Switch to the common signing secrets used across the
other pipelines (PACKAGING_SECRET_KEY / PACKAGING_PASSPHRASE) to match the
standard convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants