Fix wrong results for NOT (x IS DISTINCT FROM y) with recursive planning#8497
Open
bfa-dev wants to merge 4 commits intocitusdata:mainfrom
Open
Fix wrong results for NOT (x IS DISTINCT FROM y) with recursive planning#8497bfa-dev wants to merge 4 commits intocitusdata:mainfrom
bfa-dev wants to merge 4 commits intocitusdata:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
When ReplaceRTERelationWithRteSubquery wraps a local table into a subquery, restrictions are pushed into the subplan but remain on the outer query. If restriction-referenced columns are not in requiredAttrNumbers, the outer subquery projects them as NULL, causing the outer WHERE to evaluate incorrectly (e.g., NOT (0 IS DISTINCT FROM NULL) is always FALSE). Fix by including restriction-referenced column Vars in requiredAttrNumbers before building the subquery. Fixes citusdata#8468
bfa-dev
force-pushed
the
fix/8468-recursive-planning-null-restriction-columns
branch
from
9a48df9 to
3dfbc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Fixes wrong query results when recursive planning projects restriction-referenced columns as NULL
When ReplaceRTERelationWithRteSubquery wraps a local table into a subquery, restrictions are pushed into the subplan but remain on the outer query. If restriction-referenced columns are not in requiredAttrNumbers, the outer subquery projects them as NULL, causing the outer WHERE to evaluate incorrectly (e.g., NOT (0 IS DISTINCT FROM NULL) is always FALSE).
Fix by including restriction-referenced column Vars in requiredAttrNumbers before building the subquery.
Fixes #8468