Skip to content

Fix error when executing insert on secondary worker node #8419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
templarzq wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix error when executing insert on secondary worker node #8419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37f587b
Enhance task placement check with recovery status
templarzq Dec 23, 2025
84dd508
Update citus_custom_scan.c
templarzq Dec 23, 2025
4527638
Refactor task type check with RecoveryInProgress
templarzq Dec 24, 2025
ba6a442
Refactor task type check with RecoveryInProgress
templarzq Dec 25, 2025
412cda7
Merge branch 'main' into main
ihalatci Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/backend/distributed/executor/citus_custom_scan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,10 @@ IsCitusCustomScan(Plan *plan)
}

Node *privateNode = (Node *) linitial(customScan->custom_private);
//shoud check privateNode is null ptr
if (privateNode == NULL){
return false;
Copy link
Copy Markdown
Contributor

@colm-mchugh colm-mchugh Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be preferable to throw an error here, given that custom_private is unconditionally set in FinalizePlan(). If the list contains a NULL it indicates something has gone wrong before this point. Suggest debugging FinalizePlan() from the point where custom_private is set, and try to determine if the CustomScan node is initialized correctly there and where it changes state to result in the problem here.

}
if (!CitusIsA(privateNode, DistributedPlan))
{
return false;
Expand Down
9 changes: 8 additions & 1 deletion src/backend/distributed/executor/local_executor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,14 @@ TaskAccessesLocalNode(Task *task)
{
if (taskPlacement->groupId == localGroupId)
{
return true;
//check if it's running on standby node
if( (task->taskType == MODIFY_TASK||
task->taskType ==DDL_TASK) && RecoveryInProgress())
{
return false;
}else{
return true;
}
}
}

Expand Down