Improve connection step updating and add checkmarks#298
Improve connection step updating and add checkmarks#298tannewt merged 2 commits intocircuitpython:betafrom
Conversation
tannewt
left a comment
There was a problem hiding this comment.
Would this work with an emoji check instead of an svg?✔️
Also, could you add a short screen capture to show what this looks like? Thanks!
|
Sure, I could give it a try. It should work in theory. I'll see how it looks though. |
|
I think the SVG looks better. Here's a comparison: Here' a screen recording to see it in action: |
|
Thank you for the screen recording! Do we need to show step 1 at that point at all? Why not just show step 2? Earlier it only shows step 1. |
|
It allows users to still connect to a different device in case they selected the wrong one or to go forward with step 2. |
|
I'm not convinced you need to do that here. They can always disconnect and click connect again. If you do want to show it still, then I'd update the step 1 info with what was selected. That way one can tell if the correct thing was selected. |
|
After trying out some things, I think you're correct. I updated the code to disable the Connect to Device button. I don't want to remove the step altogether because the CSS would automatically renumber the steps and step 2 would appear to be step 1. |
|
One thing I noticed recently is that when the UF2 is downloaded and then uploaded to the board, the progress bar just says "Downloading": it's not two steps. Or am I missing something? |
Sorry, never mind, thought this was the web installer. |


This completes another step in #43. While adding code to mark steps complete, I was able to abstract the function to enable/disable buttons.