Skip to content

Ensure html attributes are escaped in templates #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colemanw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure html attributes are escaped in templates #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="iso-8859-1" ?>
<extension key="uk.co.circleinteractive.offlinerecurring" type="module">
<?xml version="1.0" encoding="iso-8859-1"?>
<extension key="uk.co.circleinteractive.offlinerecurring" type="module">
<downloadUrl>http://extensions.circle-interactive.co.uk/uk.co.circleinteractive.offlinerecurring-v1.6.zip</downloadUrl>
<file>offlinerecurring</file>
<name>Offline Recurring Payment</name>
Expand All @@ -19,10 +19,7 @@
<version>1.6</version>
<develStage>stable</develStage>
<compatibility>
<ver>4.1</ver>
<ver>4.2</ver>
<ver>4.3</ver>
<ver>4.4</ver>
<ver>5.65</ver>
</compatibility>
<comments>For support, please contact project team on the forums. (http://forum.civicrm.org)</comments>
</extension>
</extension>
2 changes: 1 addition & 1 deletion legacy/templates/CRM/Contribute/Form/ContributionView.old.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
{if $softCreditToName}
<tr>
<td class="label">{ts}Soft Credit To{/ts}</td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts}View contact record{/ts}">{$softCreditToName}</a></td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts escape='htmlattribute'}View contact record{/ts}">{$softCreditToName}</a></td>
</tr>
{/if}
</table>
Expand Down
4 changes: 2 additions & 2 deletions legacy/templates/CRM/Contribute/Form/ContributionView.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
{if $softCreditToName and !$pcp_id} {* We show soft credit name with PCP section if contribution is linked to a PCP. *}
<tr>
<td class="label">{ts}Soft Credit To{/ts}</td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts}View contact record{/ts}">{$softCreditToName}</a></td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts escape='htmlattribute'}View contact record{/ts}">{$softCreditToName}</a></td>
</tr>
{/if}
</table>
Expand Down Expand Up @@ -251,7 +251,7 @@
</tr>
<tr>
<td class="label">{ts}Soft Credit To{/ts}</td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts}View contact record{/ts}">{$softCreditToName}</a></td>
<td><a href="{crmURL p="civicrm/contact/view" q="reset=1&cid=`$soft_credit_to`"}" id="view_contact" title="{ts escape='htmlattribute'}View contact record{/ts}">{$softCreditToName}</a></td>
</tr>
<tr><td class="label">{ts}In Public Honor Roll?{/ts}</td><td>{if $pcp_display_in_roll}{ts}Yes{/ts}{else}{ts}No{/ts}{/if}</td></tr>
{if $pcp_roll_nickname}
Expand Down