Provide method documentation for the unit class#19
Draft
jejanim wants to merge 4 commits intocipherxof:masterfrom
Draft
Provide method documentation for the unit class#19jejanim wants to merge 4 commits intocipherxof:masterfrom
jejanim wants to merge 4 commits intocipherxof:masterfrom
Conversation
Owner
|
You may also want to look at https://github.com/lep/jassdoc Maybe a script could be made to automate the docs from there, although there may be some slight API differences with the wrappers. |
Contributor
Author
|
Thanks for the reference, I will see what I can do. |
Contributor
Author
|
I found a duplicate function that might be there to prevent breaking changes, not sure. Care to keep it? public hideAbility(abilId: number, flag: boolean) {
BlzUnitHideAbility(this.handle, abilId, flag);
}(the third param (hideUI) is unused but I think it's more descriptive than flag and could replace it) public disableAbility(abilId: number, flag: boolean, hideUI: boolean) {
BlzUnitHideAbility(this.handle, abilId, flag);
} |
Owner
Fixed da1febb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still
work-in-progress...I'm not an expert on those functions or the editor fields in general but I consulted the following references: