test(matrix): capture int4 matrix executed SQL#248
Draft
tobyhede wants to merge 1 commit into
Draft
Conversation
Add `tasks/test/matrix/capture.sh` (mise task `test:matrix:capture`): a local-only tool that runs the int4 encrypted-domain test matrix under `log_statement='all'` and extracts the SQL Postgres actually executes, so the real operator/cast/index coverage can be inspected against the documented surface. The matrix builds its SQL at runtime via `format!`, so the executed statements are the only ground truth. Flow: rebuild EQL + refresh the install migration (a stale migration silently reports the wrong surface) -> flip log_statement via ALTER SYSTEM + reload (trap resets on exit) -> run the matrix serially -> reassemble multi-line statements from the logs into raw + filtered dumps. Notable correctness points baked in: - Capture the EXTENDED protocol (`LOG: execute`) only: that is what sqlx issues for every test query; the simple-protocol `statement:` stream is the install/migration, not the surface under test. - Reassemble multi-line statements (the planner-metadata catalog query starts with a newline and would otherwise be truncated to nothing). - --test-threads=1 so concurrent backends don't interleave un-prefixed continuation lines into corrupt merged statements. - Filter admits the temp-table-column probes (typed_col/typed_count blockers, min/max aggregates) that carry no eql_v2 token, and drops install/setup noise. Local verification tool only: no coverage gate, no CI wiring.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
mise run test:matrix:capture: local-only tool that runs the int4 matrix underlog_statement='all'and dumps the SQL Postgres actually executes (raw + filtered) for coverage inspection. No CI wiring.