Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project's Gradle version and migrates from Apache Commons Lang to Lang3, along with various code improvements and test coverage enhancements.
Key Changes:
- Upgraded Gradle from version 7.6 to 8.12
- Migrated from
apache.commons.langtoapache.commons.lang3with updated API method calls - Enhanced test coverage with new test cases and assertions
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/wrapper/gradle-wrapper.properties | Updated Gradle distribution from 7.6 to 8.12 |
| src/main/java/org/cip4/jdfutility/server/JettyServer.java | Changed import from commons-lang to commons-lang3 and added getter for Jetty server instance |
| src/main/java/org/cip4/jdfutility/GetFileServlet.java | Migrated from StringEscapeUtils.escapeHtml to escapeHtml3 and reorganized imports |
| src/main/java/org/cip4/jdfutility/server/MyResourceHandler.java | Replaced string literals with JDFConstants.SLASH and improved URL manipulation logic |
| src/main/java/org/cip4/jdfutility/FileItemList.java | Added FileCleaningTracker support with getter/setter methods and exception handling |
| src/main/java/org/cip4/jdfutility/CheckJDFServlet.java | Initialized FileCleaningTracker to null in constructor |
| src/test/java/org/cip4/jdfutility/FileItemListTest.java | Added test for FileCleaningTracker functionality |
| src/test/java/org/cip4/jdfutility/server/MyResourceHandlerTest.java | Enhanced tests with additional assertions for URL handling |
| src/test/java/org/cip4/jdfutility/server/JettyServerTest.java | Added assertion to verify Jetty server getter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # build.gradle # src/main/java/org/cip4/jdfutility/FileItemList.java # src/main/java/org/cip4/jdfutility/GetFileServlet.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.