Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Preview: https://2747--pr-cinny.netlify.app |
|
It is not fully done yet, and it evolves lots of file changes, let me know if this contribution makes sense for you, or how can I make it more reviewable. |
|
Hey @weareoutman, it largely looks good. can we have an option in settings to change the language to test so we can switch it without totally depending on system wide language change. And also can track the progress of what has/not been translated in issue |
|
Rebased and ready for review 🍻 |
|
@weareoutman Personal opinion here - I would separate the implementation of i18n support from a PR with your translations to another language. These are two separate things to review and fall under different scrutiny, besides until it's decided what should be translated, performing translations may waste work. |
From my experience, most websites and apps don't offer the 'System setting' option for language. Edit:
It's a placeholder, so I think translation here is reasonable.
Yes, changes are massive, so I have to use some tools, but all with careful manual review and corrections.
I agree with that, but the initial i18n support was already done in #1576 , this PR only introduces translations and a language selection in settings panel. @Stealthii Thanks for your advice. |
|
@ajbura Congrats on your newly release which supports Voice/Video calls, that's a great work. Do you have time to review this? I'll rebase it once you'd like to review, since the chance of conflicts is high for each new commits on the main branch. |
|
@weareoutman Thanks you for the support! While it looks good overall. I can not review the zh.json file as I do not know the language. As said by other contributor I also think it would be a good idea to have zh change as a new PR so we can ask other community member who are speaker of language for review without blocking the translation support changes. |


Description
This PR adds i18n for almost all pages, while #1576 introduced i18next but never progressed on again.
Type of change
Checklist: