Change play icon and add clickable backdrop on embedded videos.#2740
Open
Johnnycyan wants to merge 1 commit intocinnyapp:devfrom
Open
Change play icon and add clickable backdrop on embedded videos.#2740Johnnycyan wants to merge 1 commit intocinnyapp:devfrom
Johnnycyan wants to merge 1 commit intocinnyapp:devfrom
Conversation
…at can be clicked in addition to the button area to initiate video playback.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Mar 7, 2026
ajbura
requested changes
Mar 13, 2026
Member
ajbura
left a comment
There was a problem hiding this comment.
i would like to keep the watch button as change makes it keyboard unfriendly and also does not follow design system.
a better alternative could be to just add the onClick and onKeyDown to the outer AbsoluteContainer.
also i think the problem is little more complex as the video can be spoiler also and same UX also need to be maintained with the Image message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small change that just updates the icon displayed over embedded videos to be more minimal, with a slight hover animation, and allows the user to click the entire video embed area to initiate playback instead of just the button itself.
If you would prefer to keep the old button style but still add the backdrop clickable area, I could modify the change to do that. I just felt as though the button didn't really look right.
Comments weren't necessary as this is a very small change.
My reason for making this change is because when I was using Cinny and a friend sent me a video, the first thing I tried to do was just click the video area, and nothing happened. This initially led me to believe I had to download the video to watch it as I didn't notice the "Watch" button initially.
msedge_8zMThArQKJ.mp4
Type of change
Checklist: