Skip to content

fix: change emojis & stickers pack selector button to dropdown #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smokku wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: change emojis & stickers pack selector button to dropdown #2733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/app/features/settings/emojis-stickers/GlobalPacks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,15 @@ function GlobalPackSelector({
</Text>
</Box>
<Box shrink="No">
<Chip
radii="Pill"
variant={hasSelected ? 'Success' : 'SurfaceVariant'}
outlined={hasSelected}
<Button
size="300"
radii="300"
variant={hasSelected ? 'Success' : 'Secondary'}
fill={hasSelected ? 'Solid' : 'Soft'}
onClick={() => onSelect(selected)}
Comment on lines +114 to 119
Copy link
Copy Markdown
Collaborator

@kfiven kfiven Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR. Chevron is nice addition.

In our design language, buttons are not used in header component. How something like in picture below if the current button is not noticeable?

Image

Copy link
Copy Markdown
Author

@smokku smokku Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nagranie.ekranu_20260316_123825.webm

With my eyes focused on the mouse pointer, with all the green around, my old eyes did not notice that at the edge of field of vision something changed from light gray, to light green…

image

Copy link
Copy Markdown
Collaborator

@kfiven kfiven Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the Apply Changes approach shown in my last message looks to you?

Copy link
Copy Markdown
Author

@smokku smokku Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the Apply Changes approach shown in my last message looks to you?

It is visible enough. :-)

Copy link
Copy Markdown
Collaborator

@kfiven kfiven Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, can we do that for save button?

>
<Text size="B300">{hasSelected ? 'Save' : 'Close'}</Text>
</Chip>
</Button>
</Box>
</Header>
<Line variant="Surface" size="300" />
Expand Down Expand Up @@ -439,6 +440,7 @@ export function GlobalPacks({ onViewPack }: GlobalPacksProps) {
size="300"
radii="300"
outlined
after={<Icon size="300" src={Icons.ChevronBottom} />}
>
<Text size="B300">Select</Text>
</Button>
Expand Down
Loading