Fix emojis showing title instead of popup shortcode#2732
Open
aryanjassal wants to merge 1 commit intocinnyapp:devfrom
Open
Fix emojis showing title instead of popup shortcode#2732aryanjassal wants to merge 1 commit intocinnyapp:devfrom
aryanjassal wants to merge 1 commit intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Mar 5, 2026
|
Preview: https://2732--pr-cinny.netlify.app |
ajbura
requested changes
Mar 13, 2026
Member
ajbura
left a comment
There was a problem hiding this comment.
overall looks good. I think we also need to add this to the custom emojis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
titlepopup with a tooltip for displaying the shortcode of an emoji in messages within a room. This also aligns the behaviour with hovering over a reaction.Fixes #2652
Type of change
Checklist: