feature: when editing with an empty body, delete the message#2707
Open
malwarepad wants to merge 3 commits intocinnyapp:devfrom
Open
feature: when editing with an empty body, delete the message#2707malwarepad wants to merge 3 commits intocinnyapp:devfrom
malwarepad wants to merge 3 commits intocinnyapp:devfrom
Conversation
|
I love this but maybe it should be made so it opens the confirm delete screen |
Author
Just did some refactoring and implemented that. I also made the confirmation button immediately focused, so that you can double enter for quick deletion (like in Discord) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
When trying to edit a message with an empty body, it gets deleted. Silently fails if user doesn't have the correct permissions.
Type of change
Checklist: