Fix email notification toggle UX and layout shifting#2668
Open
Tarfua wants to merge 2 commits intocinnyapp:devfrom
Open
Fix email notification toggle UX and layout shifting#2668Tarfua wants to merge 2 commits intocinnyapp:devfrom
Tarfua wants to merge 2 commits intocinnyapp:devfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
ajbura
added a commit
to cinnyapp/cla
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the Email Notification toggle by implementing optimistic UI and stabilizing the state to prevent layout shifting.
Problem
The setting tile flickered or disappeared during SDK data refreshes. There was a lack of immediate feedback when toggling the switch. Additionally, the append flag could lead to duplicate email pushers on the server.
Changes
The last valid server result is now cached using
useRefanduseMemoto ensure UI consistency during asynchronous updates. A local state provides an instant toggle response with a rollback mechanism in case of failure. Full-tile loading was replaced with a disabled state and a side-by-side Spinner for better UX. The append flag was removed from thesetPushercall to ensure unique entries on the server.Type of change
Checklist: