Skip to content

feat(sdp): Updating the ip to endpoint table for sdp#41548

Merged
squeed merged 3 commits intocilium:mainfrom
vipul-21:singhvipul/sdp-6
Nov 5, 2025
Merged

feat(sdp): Updating the ip to endpoint table for sdp#41548
squeed merged 3 commits intocilium:mainfrom
vipul-21:singhvipul/sdp-6

Conversation

@vipul-21
Copy link
Copy Markdown
Contributor

@vipul-21 vipul-21 commented Sep 5, 2025

  • Adds the ip to endpoint info i.e identity and endpoint id in the table.
  • Adds a watcher that listens for changes in the table and updates the prefixs for faster lookup.
  • Lookup handlers for DNS proxy for serving the DNS req.
  • Send the identity<>cidr map from the cilium agent. These cidr are not associated with
    an endpoint.

Fixes: #30984
CFP: cilium/design-cfps#54
Relevant PRs: #40982, #41507

feat(sdp): Updating the ip to endpoint table for sdp

@maintainer-s-little-helper maintainer-s-little-helper Bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 5, 2025
@vipul-21 vipul-21 force-pushed the singhvipul/sdp-6 branch 3 times, most recently from af2e445 to bdc93ac Compare September 9, 2025 23:56
@vipul-21 vipul-21 marked this pull request as ready for review September 10, 2025 00:07
@vipul-21 vipul-21 requested a review from a team as a code owner September 10, 2025 00:07
@vipul-21 vipul-21 requested a review from squeed September 10, 2025 00:07
@vipul-21

This comment was marked as outdated.

@vipul-21 vipul-21 marked this pull request as draft September 10, 2025 18:28
@vipul-21 vipul-21 marked this pull request as ready for review September 10, 2025 18:44
@vipul-21

This comment was marked as outdated.

@vipul-21

This comment was marked as outdated.

@vipul-21

This comment was marked as outdated.

@vipul-21

This comment was marked as outdated.

1 similar comment
@vipul-21

This comment was marked as outdated.

@pchaigno

This comment was marked as outdated.

@vipul-21

This comment was marked as outdated.

1 similar comment
@vipul-21

This comment was marked as outdated.

Comment thread standalone-dns-proxy/pkg/client/client.go
Comment thread pkg/fqdn/service/service.go Outdated
Comment thread standalone-dns-proxy/pkg/client/client.go
Comment thread standalone-dns-proxy/pkg/client/client.go
@vipul-21 vipul-21 requested a review from squeed September 30, 2025 21:56
@vipul-21 vipul-21 requested a review from a team as a code owner October 3, 2025 21:45
@vipul-21 vipul-21 force-pushed the singhvipul/sdp-6 branch 2 times, most recently from c47c5ff to 09b8fea Compare October 3, 2025 21:50
@vipul-21

This comment was marked as outdated.

@vipul-21

This comment was marked as outdated.

Comment thread standalone-dns-proxy/pkg/lookup/lookup.go Outdated
@vipul-21 vipul-21 requested a review from joamaki October 29, 2025 21:19
@vipul-21
Copy link
Copy Markdown
Contributor Author

/test

@vipul-21
Copy link
Copy Markdown
Contributor Author

@squeed / @joamaki Friendly ping for reviewing the PR.

@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label Nov 1, 2025
@maintainer-s-little-helper maintainer-s-little-helper Bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2025
Comment thread standalone-dns-proxy/pkg/lookup/lookup_test.go Outdated
Copy link
Copy Markdown
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, then this is good to go.

@maintainer-s-little-helper maintainer-s-little-helper Bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 4, 2025
- Adds the ip to endpoint info i.e identity and endpoint id in the table.
- Adds a watcher that listens for changes in the table and updates the prefixs for
faster lookup.
- Lookup handlers for DNS proxy for serving the DNS req.
- Send the identity<>cidr map from the cilium agent. These cidr are not associated with
an endpoint.

Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
… SDP

- Introduce separate tables for prefix-to-identity mapping and IP-to-endpoint mapping.
- Update the SDP lookup function to use these new tables when resolving endpoints and
identities during DNS request processing.
- Modify the existing protobuf definition for the standalone DNS proxy to send the
prefix-to-identity mapping separately.

Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
Signed-off-by: Vipul Singh <singhvipul@microsoft.com>
@vipul-21
Copy link
Copy Markdown
Contributor Author

vipul-21 commented Nov 4, 2025

/test

@vipul-21
Copy link
Copy Markdown
Contributor Author

vipul-21 commented Nov 5, 2025

Conformance Gateway API (ci-gateway-api) - open GH issue: #40243 and #42456

@vipul-21
Copy link
Copy Markdown
Contributor Author

vipul-21 commented Nov 5, 2025

/ci-gateway-api

@vipul-21
Copy link
Copy Markdown
Contributor Author

vipul-21 commented Nov 5, 2025

Cilium E2E Upgrade (ci-e2e-upgrade) - failing due to a warning log that has a retry mechanism:

time=2025-11-04T23:38:20.750321606Z level=warn source=/go/src/github.com/cilium/cilium/pkg/datapath/orchestrator/orchestrator.go:229 msg="Failed to initialize datapath, retrying later" module=agent.datapath.orchestrator error="inserting ipv4 proxy route {proxy 2004 0.0.0.0/0 0 100 false invalid IP 0.0.0.0 0xc0026b80a0 0 universe local {{0 0 } 0 {0}}}: timeout waiting for parameter proxy:2004:0.0.0.0/0 reconciliation: %!w()" retryDelay=10s (1 occurrences)

@vipul-21
Copy link
Copy Markdown
Contributor Author

vipul-21 commented Nov 5, 2025

/ci-e2e-upgrade

@squeed squeed added this pull request to the merge queue Nov 5, 2025
Merged via the queue into cilium:main with commit 8904108 Nov 5, 2025
73 checks passed
@cilium-release-bot cilium-release-bot Bot moved this to Released in cilium v1.19.0 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.

Projects

No open projects
Status: Released

Development

Successfully merging this pull request may close these issues.

CFP: Introduce HA mode for DNS proxy

4 participants