Skip to content

[Snyk] Security upgrade next from 13.4.19 to 14.2.35#3

Open
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-af6c4ea612e4c4f74d5adc188815afde
Open

[Snyk] Security upgrade next from 13.4.19 to 14.2.35#3
arthrod wants to merge 1 commit into
mainfrom
snyk-fix-af6c4ea612e4c4f74d5adc188815afde

Conversation

@arthrod
Copy link
Copy Markdown
Collaborator

@arthrod arthrod commented Dec 15, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • package.json
  • package-lock.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Deserialization of Untrusted Data
SNYK-JS-NEXT-14400636
  852  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Deserialization of Untrusted Data

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 15, 2025

Important

Review skipped

Ignore keyword(s) in the title.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch snyk-fix-af6c4ea612e4c4f74d5adc188815afde

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving a critical vulnerability within the Next.js framework. The primary action is a significant version bump of Next.js, which in turn cascades updates across several underlying packages to ensure compatibility and incorporate the necessary security patches.

Highlights

  • Security Vulnerability Fix: This pull request addresses a high-severity 'Deserialization of Untrusted Data' vulnerability (SNYK-JS-NEXT-14400636) identified in the next package.
  • Next.js Upgrade: The core of this fix involves upgrading the next dependency from version 13.4.19 to 14.2.35.
  • Dependency Updates: Multiple transitive dependencies, including various @next/swc-* packages, @swc/helpers, nanoid, and postcss, have been updated as a result of the Next.js upgrade.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades the next package from version 13.4.19 to 14.2.35 to address a security vulnerability. This is a major version upgrade, which introduces breaking changes.

My review has identified a couple of points that should be addressed to ensure a smooth upgrade:

  • The eslint-config-next dev dependency should be updated to 14.2.35 to align with the new next version.
  • The next version in package-lock.json is specified with a caret (^14.2.35), while package.json pins it to an exact version. It's better to keep them consistent by using the exact version in the lock file as well.
  • With Next.js v14, the experimental.forceSwcTransforms option in next.config.js is no longer needed and can be removed.

I've added specific comments on the relevant files. Overall, this is a necessary security upgrade, and with these adjustments, it should be ready to merge.

Comment thread package.json
"@trpc/server": "^10.45.0",
"express": "^4.18.2",
"next": "13.4.19",
"next": "14.2.35",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR upgrades next to a new major version. To ensure compatibility and correct linting rules, the eslint-config-next package in devDependencies should also be updated from 13.4.19 to match the new next version (14.2.35).

Comment thread package-lock.json
"@trpc/server": "^10.45.0",
"express": "^4.18.2",
"next": "13.4.19",
"next": "^14.2.35",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The next dependency in package-lock.json is set to ^14.2.35, which allows for future minor and patch updates. However, package.json pins it to the exact version 14.2.35. For consistency and to prevent unexpected updates, this should be pinned to the exact version in the lockfile as well.

Suggested change
"next": "^14.2.35",
"next": "14.2.35",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants