Improve space-based shiftwidth detection#16
Open
aclindsa wants to merge 6 commits intociaranm:masterfrom
Open
Conversation
The previous method of using the shortest existing tab spacing worked some of the time, but isn't as robust as the GCD method (i.e. if there was one or two lines that started with only one space, but the rest of the lines started with four spaces, the old method would set shiftwidth to 1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've modified your detectindent script slightly to change how the number of spaces per tab is detected. It seems to have improved the detection a little, and figured I'd let you know in case you wanted to incorporate any of my changes back into your tree.
Thanks!