fix: guard ability category registration against double-fire _doing_it_wrong notice#130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The notice
Root cause
On the Extra Chill multisite, WordPress core's
wp_abilities_api_categories_initaction fires more than once per request. Core'sWP_Ability_Categories_Registry::register()warns via_doing_it_wrongwhenever an already-registered category gets registered again.bfb_register_ability_category()calledwp_register_ability_category()unconditionally inside itswp_abilities_api_categories_initcallback, with no idempotency guard — so on the second hook fire it re-registered theblock-format-bridgecategory and tripped the notice.The fix
Guard the registration with core's idempotency check
wp_has_ability_category()(itself guarded withfunction_existssince it ships with the same core API). A repeat fire is now a clean no-op. The existingfunction_exists( 'wp_register_ability_category' )guard is preserved. No change to the slug, label, description, or hook.This plugin registers a single category (
block-format-bridge); that one call is now guarded.