Skip to content

Update MENU_ACTION_DESCRIPTOR_VANILLA signature#1677

Merged
chsami merged 1 commit intochsami:developmentfrom
gmason0:fix/menuaction
Feb 8, 2026
Merged

Update MENU_ACTION_DESCRIPTOR_VANILLA signature#1677
chsami merged 1 commit intochsami:developmentfrom
gmason0:fix/menuaction

Conversation

@gmason0
Copy link
Contributor

@gmason0 gmason0 commented Feb 6, 2026

Rev 236 changed menu action descriptor from "(IIIIIILjava/lang/String;Ljava/lang/String;IIB)V" -> "(IIIIIILjava/lang/String;Ljava/lang/String;III)V"

Rev 236 changed menu action descriptor from "(IIIIIILjava/lang/String;Ljava/lang/String;IIB)V" -> "(IIIIIILjava/lang/String;Ljava/lang/String;III)V"
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Walkthrough

The expected method descriptor for vanilla menu action invocation in the reflection utility was updated. The descriptor string for identifying the correct vanilla method signature was modified from ending with IIB to ending with III, changing the final parameter type from byte to int. This adjustment aligns the reflection-based method lookup with the actual vanilla method implementation. The method discovery logic, garbage value extraction, fallback behavior, and invocation flow remain unchanged.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating the MENU_ACTION_DESCRIPTOR_VANILLA signature from one format to another.
Description check ✅ Passed The description directly relates to the changeset, explaining the specific signature change from Rev 236 that the code update addresses.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chsami chsami merged commit c2ab26c into chsami:development Feb 8, 2026
2 checks passed
chsami added a commit that referenced this pull request Feb 8, 2026
Merge pull request #1677 from gmason0/fix/menuaction

Update MENU_ACTION_DESCRIPTOR_VANILLA signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants