Fix Hive enum drift regressions and Wax memory clear persistence#64
Open
christopherkarani wants to merge 1 commit intomainfrom
Open
Fix Hive enum drift regressions and Wax memory clear persistence#64christopherkarani wants to merge 1 commit intomainfrom
christopherkarani wants to merge 1 commit intomainfrom
Conversation
…ax clear semantics - add missing fork lifecycle canonicalization in HiveDeterminism transcript projection - handle newly added HiveRuntimeError cases in GraphAgent error mapper to avoid silent fallthrough - update checkpoint query test for typed unsupported(operation:) API - add regression test covering forkStarted/forkCompleted/forkFailed canonical transcript attributes - fix WaxMemory.clear() to remove persisted Wax artifacts before reopening store - verify with focused and full runs: swift test --filter determinismUtilities_canonicalizesForkEvents, swift test --filter WaxMemoryTests, swift test, swift build
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes mission-critical correctness issues surfaced during the framework audit and hardens regression coverage.
What was fixed
Compile blocker (P0): non-exhaustive
HiveEventKindswitch in determinism canonicalization.HiveDeterminism.canonicalKind(_:)to handle fork lifecycle events:forkStartedforkCompletedforkFailedCorrectness gap (P1): non-exhaustive
HiveRuntimeErrormapping inGraphAgent.checkpointNotFoundresumeInterruptMismatchforkSourceCheckpointMissingforkCheckpointStoreMissingforkCheckpointQueryUnsupportedforkTargetThreadConflictforkSchemaGraphMismatchforkMalformedCheckpointAPI compatibility fix (P1): updated checkpoint query test expectation to typed enum payload.
HiveCheckpointQueryErrorassertion to.unsupported(operation: .listCheckpoints).Data correctness / isolation bug (P1):
WaxMemory.clear()did not clear persisted backing data.clear()now removes persisted Wax artifacts before reopening the store.Regression tests added (P1):
ChatGraphTests.Validation
swift test --filter determinismUtilities_canonicalizesForkEventsswift test --filter WaxMemoryTestsswift testswift buildAll commands pass locally.
Files touched
Sources/Swarm/HiveSwarm/RuntimeHardening.swiftSources/Swarm/HiveSwarm/GraphAgent.swiftSources/Swarm/Integration/Wax/WaxMemory.swiftTests/HiveSwarmTests/ChatGraphTests.swift