Skip to content

Address issue #44 (touch event for mobile)#53

Open
tgmof wants to merge 6 commits intochrisrzhou:mainfrom
tgmof:address-issue-44
Open

Address issue #44 (touch event for mobile)#53
tgmof wants to merge 6 commits intochrisrzhou:mainfrom
tgmof:address-issue-44

Conversation

@tgmof
Copy link
Copy Markdown

@tgmof tgmof commented Jan 1, 2021

Adding the touch event behaviour
Aligning it with the click event (focus, defocus and quick tooltip appearance)

@mledwards
Copy link
Copy Markdown

This is working great! Can it be merged in?

@mledwards
Copy link
Copy Markdown

mledwards commented Mar 3, 2021

I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.

This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head

@halfgian
Copy link
Copy Markdown

halfgian commented Jun 4, 2021

Can this be merged? It is super useful. @chrisrzhou

@tgmof
Copy link
Copy Markdown
Author

tgmof commented Jun 4, 2021

@mledwards

I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.

This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head

No idea, but indeed I never succeeded to run that directly in another project, I always used it as an external package and referencing it this way (manually) in the package.json:
https://github.com/tgmof/me/blob/master/package.json#L16 (with a different link to match this PR only)
Before running a sync to fetch all required packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants