You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.
This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head
I'm getting an issue when using this in a create-react-app yarn build, it's saying we're using experimental JSX syntax when looking at lines like {{ height, width }}, which is weird because that's the same lines from the main repo, where I don't get that error.
This could be the way I'm installing the PR directly with yarn add chrisrzhou/react-globe#pull/53/head
No idea, but indeed I never succeeded to run that directly in another project, I always used it as an external package and referencing it this way (manually) in the package.json: https://github.com/tgmof/me/blob/master/package.json#L16 (with a different link to match this PR only)
Before running a sync to fetch all required packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the touch event behaviour
Aligning it with the click event (focus, defocus and quick tooltip appearance)