Skip to content

Update INSTALL.sh #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mizumo-prjkt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update INSTALL.sh #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion INSTALL.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,18 @@
#!/usr/bin/env bash

# First install the configuration files:
# Important: The script should check if DKMS is Present, because its important so no one would cry at issues
CHECK=$(command -v dkms 2>/dev/null)
if [ -n "$CHECK" ]
then
echo "DKMS Present, Istalling Anbox Modules"
else
echo "DKMS Did not respond, it seems that DKMS is not Present or you are not running in sudo/root mode"
echo "To make sure, please install dkms and try running the script again with sudo"
Comment on lines +5 to +10
Copy link

@Thesola10 Thesola10 Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if [ -n "$CHECK" ]
then
echo "DKMS Present, Istalling Anbox Modules"
else
echo "DKMS Did not respond, it seems that DKMS is not Present or you are not running in sudo/root mode"
echo "To make sure, please install dkms and try running the script again with sudo"
if ! [ -n "$CHECK" ]
then
>&2 echo "DKMS command not found, it seems that DKMS is not installed or you do not have permission to use it."
>&2 echo "Please install the dkms package from your distribution vendor and re-run this tool as root."

I don't think we need to explicitly state that we found DKMS, don't mind the quick reword

exit 1
fi
unset CHECK

# Start the Operation! : install the configuration files:
sudo cp anbox.conf /etc/modules-load.d/
sudo cp 99-anbox.rules /lib/udev/rules.d/

Expand Down