(#3477, #3635) Replace Get-ChocolateyUnzip command with Expand-ChocolateyArchive#3797
Open
vexx32 wants to merge 2 commits intochocolatey:feature/cmdletsfrom
Open
(#3477, #3635) Replace Get-ChocolateyUnzip command with Expand-ChocolateyArchive#3797vexx32 wants to merge 2 commits intochocolatey:feature/cmdletsfrom
vexx32 wants to merge 2 commits intochocolatey:feature/cmdletsfrom
Conversation
9 tasks
Member
|
I haven't looked at the code yet, but I was curious whether we want the name of the environment variable, feature and/or parameter to be consistent with what we are using during the initial installation of Chocolatey CLI? If so, the environment variable we have then is called: |
Member
Author
|
I'm not really tied to the specific names we chose for the PR, but. As for those, I did avoid naming it similarly somewhat deliberately;
If we were to rename the feature/parameter I would probably suggest the better alternate name is something about disabling the usage of 7zip, it's better to be explicit about what it does than vague IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Get-ChocolateyUnzipfunctionExpand-ChocolateyArchivecmdletuseBuiltinCompressionfeature to bypass 7zip if neededMotivation and Context
#3477
Testing
./Invoke-Tests.ps1Operating Systems Testing
Win11
Change Types Made
Change Checklist
Related Issue
Fixes #3635
See also #3477