(#3641) Correctly identify root of drive sources#3788
Open
corbob wants to merge 3 commits intochocolatey:developfrom
Open
(#3641) Correctly identify root of drive sources#3788corbob wants to merge 3 commits intochocolatey:developfrom
corbob wants to merge 3 commits intochocolatey:developfrom
Conversation
corbob
force-pushed
the
3641-fix-drive-root-sources
branch
3 times, most recently
from
1d62d32 to
9345924
Compare
corbob
commented
Sep 17, 2025
corbob
commented
Sep 17, 2025
vexx32
reviewed
Sep 22, 2025
This commit adds tests to ensure a source of '.' at the root of a drive resolves correctly.
corbob
force-pushed
the
3641-fix-drive-root-sources
branch
from
9345924 to
54f2f0a
Compare
With the implementation of appending a directory separator to the source when it doesn't already end in one, this caused the comparison of a test to failure. This commit updates that expectation to include the trailing directory separator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update the lookup of a source when the source was requested as
.and working directory is the root of a drive.Motivation and Context
When a source is specified as
.and we're at the root of the drive, sometimes we get the path asc:which when treated as a repository source does not resolve correctly.Testing
Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
.when running from the root of a drive #3641