-
Notifications
You must be signed in to change notification settings - Fork 0
Fix config file installation for modules without .dmr files #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
|
@copilot co tu sie odwala?! Dlaczego sa w ogole jakies dwa parametry - config-dir i config-dst?! Pliki konfiguracyjne znajduja sie tylko wewnatrz paczki i z niej maja byc pobierane. Nie wiem po co mialby byc jakis parametr do |
… only Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Przepraszam za zamieszanie. Przywróciłem oryginalny kod (commit b69dd61). Masz rację - pliki konfiguracyjne muszą pochodzić tylko z paczki modułu. Ale żeby naprawić oryginalny problem, potrzebuję więcej informacji:
Błąd może być spowodowany tym, że:
Odnośnie parametrów: |
|
@copilot odpal sobie sam tę komendę i wróć do mnie jak Ci zadziała. |
When a module doesn't have a .dmr resource file, the entire package contents are now copied to output_dir/module_name/ directory. This ensures config files and other resources are accessible. Also fixed config directory name lookup to try both "configs" (plural) and "config" (singular) as different modules may use either convention. Fixes the issue where dmclk module's config files couldn't be found. Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Uruchomiłem komendę i znalazłem problem! Komenda działała poprawnie (moduł był pobierany), ale pliki konfiguracyjne nie były dostępne po instalacji. Problem:
Naprawione w commit bd66403:
Teraz komenda działa: |
Fixes the issue where configuration files couldn't be found when installing modules that don't include
.dmrresource files.Root Cause
The module was being downloaded correctly, but two issues prevented config files from being accessible:
Missing directory structure: When a module package doesn't include a
.dmr(resource) file, only the.dmf/.dmfcand.dmdfiles were being copied to the output directory. Other files like configs were left in the temporary extraction directory and then deleted.Directory naming mismatch: The config file lookup assumed the directory was named
config(singular), but the dmclk module package usesconfigs(plural).Changes Made
--config-diras a source location (commits b69dd61) - config files correctly come ONLY from module packages.dmrfile exists, the entire extracted package contents are now copied to<output-dir>/<module-name>/to preserve all resources including config filesconfigs/(plural) andconfig/(singular) directory names to handle different module conventionsCorrect Parameter Usage
--config-dir= Destination directory where configuration files are COPIED to--config= Path to configuration file WITHIN the module package--config-dest= Optional custom destination filenameTesting
Tested with the exact command from the issue:
Result:
The configuration file is now correctly found in the installed module and copied to the specified destination.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.