Skip to content

Fix is_file() to distinguish directories from files #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnAmadis merged 3 commits into from
Feb 10, 2026
Merged

Fix is_file() to distinguish directories from files #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94df8ef
Initial plan
Copilot Feb 10, 2026
9670969
Fix is_file() to properly distinguish files from directories
Copilot Feb 10, 2026
3c3006e
Improve variable naming in is_file() function
Copilot Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/dmdevfs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,21 @@ static int unconfigure_drivers(dmfsi_context_t ctx)
*/
static bool is_file(const char* path)
{
return Dmod_Access(path, DMOD_F_OK) == 0;
// Check if path exists
if (Dmod_Access(path, DMOD_F_OK) != 0)
{
return false;
}

// Try to open as directory - if it succeeds, it's a directory, not a file
void* dir_handle = Dmod_OpenDir(path);
if (dir_handle != NULL)
{
Dmod_CloseDir(dir_handle);
return false; // It's a directory
}

return true; // It's a file
}

/**
Expand Down