fix: 내부 문제가 있는 경우, 복구하는 방법에 예외가 잘못되어 있던 문제를 수정하라

[changuii]

변경 사항

@Test
@DisplayName("내부 문제가 있다면 외부에서 처리하도록 하는 방법은 없을까?")
void 내부_문제가_있다면_외부에서_처리하도록_하는_방법은_없을까() {
    class BrokenVendingMachine extends VendingMachine {
        @Override
        Item selectItemByName(final String name) {
            // 이 부분의 예외를 IllegalStateException으로 변경했습니다. 
            // 아래의 복구 코드와 다른 예외를 던지고 있습니다.
            throw new IllegalArgumentException("아이템을 뽑는 데 실패했습니다.");
        }
    }

    final class CustomVendingMachine extends BrokenVendingMachine {
        // TODO: 내부 문제가 있다면 외부에서 처리하도록 하는 방법은 없을까?
        @Override
        Item selectItemByName(final String name) {
            try {
                return super.selectItemByName(name);
            } catch (final IllegalStateException e) {
                // Note: 한 가지 방법을 재시도하는 것은 하나의 방법일 뿐 내부 정책에 따라 복구하는 방법은 달라질 수 있습니다. 예를 들어 해당 아이템을 뽑는데 실패했다면, 다음 아이템을 주는 방식도 복구라고 할 수 있습니다.
                return selectItemByName(name);
            }
        }
    }

• 내부 예외가, IllegalArgumentsException으로 되어 있고 외부 복구 작업 코드가 IllegalStateException으로 되어 있어 예외가 잡히지 않는 문제를 변경했습니다.

[gemini-code-assist]

Hello @changuii, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue in the ExceptionHandlingTest.java file where an incorrect exception type was being thrown within the BrokenVendingMachine class. Specifically, the code was throwing an IllegalArgumentException when it should have been throwing an IllegalStateException. This mismatch prevented the external recovery code from properly catching and handling the exception. The change modifies the exception thrown to IllegalStateException to align with the recovery logic.

Highlights

• Bug Fix: The pull request fixes a bug where the wrong exception type was being thrown, preventing proper error handling.
• Exception Handling: The pull request ensures that the correct exception is thrown, allowing the external recovery mechanism to function as intended.

Changelog

• clean-code/initial/src/test/java/cholog/ExceptionHandlingTest.java
  • Changed the exception thrown in BrokenVendingMachine.selectItemByName from IllegalArgumentException to IllegalStateException.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Trivia time!

What is the purpose of exception handling in programming?

Click here for the answer

Exception handling is a programming language construct designed to handle the occurrence of exceptions, special conditions that change the normal flow of program execution. It provides a way to gracefully recover from errors and prevent program crashes.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses an issue where the exception type thrown in the BrokenVendingMachine class did not match the exception type caught in the CustomVendingMachine class, preventing the intended exception handling logic from executing. The change modifies the exception thrown to ensure that the recovery code is properly triggered. This is a good fix to ensure the intended behavior of the exception handling mechanism.

Summary of Findings

• Exception Type Mismatch: The core issue was an IllegalArgumentException being thrown while the catch block expected an IllegalStateException. This has been corrected by changing the thrown exception to IllegalStateException.

Merge Readiness

The pull request provides a necessary fix for an exception handling issue. The change ensures that the intended recovery mechanism is triggered when an item selection fails in the vending machine simulation. Given the simplicity and correctness of the fix, the pull request is ready to be merged. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.