Skip to content

fix(ci): switch Workers Builds from npm to pnpm (closes #111) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chitcommit wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ci): switch Workers Builds from npm to pnpm (closes #111) #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6b4e8c
fix(ci): switch Workers Builds from npm to pnpm (closes #111)
chitcommit May 7, 2026
d90de07
fix(ci): remove pnpm version conflict in security-gates workflow
chitcommit May 9, 2026
6fda741
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/security-gates.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,6 @@ jobs:

- name: Install pnpm
uses: pnpm/action-setup@v4
with:
version: 10

- name: Setup Node
uses: actions/setup-node@v4
Expand Down
3 changes: 2 additions & 1 deletion deploy/system-wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
],

"build": {
"command": "npx vite build --outDir dist/public"
"command": "pnpm install --frozen-lockfile && pnpm exec vite build --outDir dist/public",
"cwd": ".."
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.

"assets": {
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "2.0.0",
"type": "module",
"license": "MIT",
"packageManager": "pnpm@10.32.1",
"scripts": {
"dev": "NODE_ENV=development tsx server/dev.ts",
"build": "vite build && esbuild server/dev.ts --platform=node --packages=external --bundle --format=esm --outdir=dist",
Expand Down
2 changes: 1 addition & 1 deletion wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"tail_consumers": [{ "service": "chittytrack" }],

"build": {
"command": "npx vite build --outDir dist/public"
"command": "pnpm install --frozen-lockfile && pnpm exec vite build --outDir dist/public"
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove CI package install from Wrangler custom build

This change puts pnpm install --frozen-lockfile into build.command, but Cloudflare Workers Builds explicitly does not honor Wrangler build custom-build settings, so this does not reliably fix the Workers Builds npm/pnpm mismatch it targets. At the same time, Wrangler custom builds run during local wrangler dev/wrangler deploy, so this introduces a repeated networked install step for every local deploy/dev path, increasing failure risk and build latency without affecting the CI path you intended to fix.

Useful? React with 👍 / 👎.

},

"assets": {
Expand Down
Loading